Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed structurized return when there are phi's from shortcircuiting. #3981

Merged
merged 3 commits into from
Oct 2, 2021
Merged

Fixed structurized return when there are phi's from shortcircuiting. #3981

merged 3 commits into from
Oct 2, 2021

Conversation

adam-yang
Copy link
Contributor

No description provided.

@AppVeyorBot
Copy link

✅ Build DirectXShaderCompiler 1.0.566 completed (commit 4be192b1ad by @adam-yang)

python3kgae
python3kgae approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@python3kgae python3kgae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a test and make sure incoming block of phi is updated if required.

@AppVeyorBot
Copy link

❌ Build DirectXShaderCompiler 1.0.584 failed (commit f489310f03 by @adam-yang)

@AppVeyorBot
Copy link

✅ Build DirectXShaderCompiler 1.0.586 completed (commit 99964f1b7c by @adam-yang)

@adam-yang adam-yang changed the title Fixed structurized return when there are additional branches Fixed structurized return when there are phi's from shortcircuiting. Oct 2, 2021
@adam-yang adam-yang merged commit 9b281d0 into microsoft:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python3kgae python3kgae python3kgae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adam-yang @AppVeyorBot @python3kgae