Fix: Correct sizeof usage in DetourTransactionCommitEx
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `sizeof(o->pTrampoline)` with `sizeof(*o->pTrampoline)` to correctly calculate the trampoline size when adjusting thread instruction pointers.
RatinCN
added a commit
to KNSoft/KNSoft.SlimDetours
that referenced
this pull request
Feb 3, 2025
This change from the bug found by @hakujitsu7 in Microsoft Detours PR microsoft#331: microsoft#331, but matches rbCode region explicitly.
Mauler125
added a commit
to Mauler125/r5sdk
that referenced
this pull request
Feb 19, 2025
- Fix incorrect sizeof() usage, see microsoft/Detours#331 - Update thread PC correctly when unhooking, see KNSoft/KNSoft.SlimDetours#2 NOTE: the sizeof() usage has been updated again from the microsoft pull request to the KNSoft one as it was supposed to be used on DETOUR_TRAMPOLINE::rbCode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in
DetourTransactionCommitExwheresizeof(o->pTrampoline)was incorrectly used instead ofsizeof(*o->pTrampoline). This caused the size of the pointer to be used rather than the size of the trampoline structure, potentially leading to incorrect adjustments of thread instruction pointers.