Merged PR 744727: [Blob L3 GC] Delete CHLs containing Unkown hashes

Delete CHLs containing Unkown hashes. I believe this happened as a side effect of attempting to delete a container while something was writing to it.
microsoft · Oct 10, 2023 · 827ee2d · 827ee2d
1 parent 461bd9d
commit 827ee2d
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/Public/Src/Cache/LifetimeManager/Library/LifetimeDatabaseCreator.cs b/Public/Src/Cache/LifetimeManager/Library/LifetimeDatabaseCreator.cs
@@ -355,6 +355,12 @@ private static async Task<Result<bool>> ProcessContentHashListAsync(
             {
                 try
                 {
+                    if (!contentHash.IsValid)
+                    {
+                        Tracer.Warning(context, $"Found invalid hash. Hash=[{contentHash.ToShortHash()}] CHL=[{blobName}]");
+                        return false;
+                    }
+
                     if (contentHash.IsEmptyHash() || contentHash.IsZero())
                     {
                         hashes.Add((contentHash, 0));