chore: Remove onnxruntime.pdb from Publishing #5291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taicchoumsft
requested review from
a-b-r-o-w-n,
boydc2014,
carlosscastro,
cwhitten and
luhan2017
as code owners
taicchoumsft
changed the title
…BotFramework-Composer into tachou/removeOnnxPdb2
tsuwandy
approved these changes
Dec 10, 2020
|
@luhan2017 can you help verify this? |
boydc2014
approved these changes
Dec 11, 2020
alanlong9278
added a commit
that referenced
this pull request
Dec 17, 2020
* main: (22 commits) fix: Added missing dependencies to /types and /extensions packages. (#4436) fix: Updated publish extensions to use updated APIs (#5346) docs: Supported/Recommended OS Documentation (#5330) chore: suppress/fix lgtm alerts (#4678) v1.3.0 release: update changelog release: update changelog github user map RC5 (#5327) fix: security analysis failed because of [email protected] (#5326) fix: undo failed after click create trigger and remove trigger (#5325) fix: LG diagnostics mismatch by update reference in cache (#5323) fix: Start panel open on start/restart operation (#5322) fix sentence wrap bug (#5310) fix: use dropdown for LUIS region in skill bot settings (#5318) chore: Updated to latest lib (#5316) feat: provisioning in app (#4221) surface dotnet build error on runtime (#5314) fix: runtime throw exception when there is no cosmosdb config (#5313) chore: Remove onnxruntime.pdb from Publishing (#5291) fix UX bug in setting page (#5306) ...
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Revert "Remove Orchestrator pdbs from Azure publish flow (microsoft#5275)" This reverts commit f94c72c. * Dummy out onnxruntime.pdb * shorten comment Co-authored-by: Dong Lei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of today, onnxruntime still does not properly separate out their large debug symbols [(see here)] (microsoft/onnxruntime#2742). Orchestrator depends on this lib.
Using flags like
CopyOutputSymbolsToPublishDirectoryanddebug=None(see here) don't work here - they work to strip out generated pdbs from the csprojs that use them, but do not strip out dependency-of-dependencies' pdbs.We perform a workaround here by zeroing out the
onnxruntime.pdb, instead of deleting it. Deleting it will cause issues when theself-containeddeploy option is selected like it is in Composer, since the deps will be written into a json file and checked for existence before the app is booted. Credit to @hanabi1224 for this idea in the link above.Saves ~20MB on upload size after zipping. Tested that bot deploys and boots to Azure WebApp.
Affects only publishing, local debugging symbols are still present in the build
OutDir.Task Item
#minor