-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] Append Efficient CUDA test for low precision batch decoding #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ability and maintainability
LeiWang1999
changed the title
[Dev] Append Efficient CUDA implementation for low precision batch decoding
[Dev] Append Efficient CUDA test for low precision batch decoding
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the codebase and add new functionalities. The most significant changes include adding a new notice for IST-DASLab/marlin in the
THIRDPARTYNOTICES.txt
file, refactoring theMatMulNTDequantizeEmitter
class in thematmul_dequantize_impl.py
file, and adding new test directories in theCMakeLists.txt
file under thetesting/cpp
directory.Addition of third party notices:
THIRDPARTYNOTICES.txt
: Added a new notice for IST-DASLab/marlin.Refactoring of existing code:
bitblas/ops/impl/matmul_dequantize_impl.py
: Refactored theMatMulNTDequantizeEmitter
class by removing unnecessary methods and simplifying the code. Also, modified thedecode_func
method in multiple places to simplify the addition of bias. [1] [2] [3] [4]Addition of new test directories:
testing/cpp/CMakeLists.txt
: Added a new subdirectoryefficient_i4_cuda_impl
for testing.testing/cpp/efficient_i4_cuda_impl/CMakeLists.txt
: Created a newCMakeLists.txt
file under theefficient_i4_cuda_impl
directory and defined functions to add CUDA and CPP test executables.