Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Refactor the ops script implementation with SE #78

Merged
merged 10 commits into from
Jul 6, 2024

Conversation

LeiWang1999
Copy link
Contributor

This pull request introduces significant changes to the bitblas/ops/impl/matmul_dequantize_impl.py and testing/python/operators/test_tir_script_emitter.py files. The most important changes include the addition of a new class MatMulNTDequantizeEmitter to refactor the code, modifications to the decode_func function, and changes to the test function compare_tir_scripts_and_emitter to include new parameters and assertions.

Additions and modifications:

  • bitblas/ops/impl/matmul_dequantize_impl.py: Added a new class MatMulNTDequantizeEmitter with various methods to refactor and simplify the code. This class includes methods for validating dimensions and bits, creating placeholders, propagating input and weight, decoding functions, computing matmul, converting dtype, and applying bias.
  • bitblas/ops/impl/matmul_dequantize_impl.py: Modified the decode_func function to include a new variable last_output and to change the order of the arguments in the args list. [1] [2] [3]

Changes to testing:

@LeiWang1999 LeiWang1999 merged commit 49c41a4 into microsoft:main Jul 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant