Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Move Relax Pass from testing to integration #77

Merged
merged 7 commits into from
Jul 6, 2024

Conversation

LeiWang1999
Copy link
Contributor

This pull request primarily involves refactoring and code quality improvements in the bitblas/ops/impl package. The changes include the introduction of abstract base classes for TIR script emitters and selectors, refactoring of the matmul_nt function into a class with methods for better organization and readability, and minor changes to suppress linting warnings.

Refactoring and code quality improvements:

  • bitblas/ops/impl/__init__.py: Suppressed a linting warning by adding # noqa: F401 to the import statement.

  • bitblas/ops/impl/base.py: Introduced abstract base classes TIRScriptEmitter and TIRScriptSelector for TIR script emitters and selectors respectively. These classes enforce the implementation of emit and select methods in any derived classes.

  • bitblas/ops/impl/batch_matmul_impl.py: Refactored the matmul_nt function into the BatchMatMulEmitter class with multiple methods for better organization and readability. This class inherits from the TIRScriptEmitter base class. A similar refactoring was done for the matmul function, which was transformed into the BatchMatMulSelector class, inheriting from the TIRScriptSelector base class. The select_implementation function was also simplified to use the newly created BatchMatMulSelector class. [1] [2]

@LeiWang1999 LeiWang1999 merged commit bf41fc4 into microsoft:main Jul 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant