Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Edit the notify setting in our CI #76

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

LeiWang1999
Copy link
Contributor

This pull request introduces a number of changes primarily aimed at refactoring the bitblas/ops/impl/batch_matmul_impl.py file for better code organization and maintainability. The changes also include modifications to the Continuous Integration (CI) workflow and some minor adjustments in other files.

Refactoring of bitblas/ops/impl/batch_matmul_impl.py:

  • The functions matmul_nt and matmul have been replaced with two new classes: BatchMatMulEmitter and BatchMatMulSelector. These classes encapsulate the same functionality but provide a more structured and maintainable approach.
  • The BatchMatMulEmitter class is responsible for emitting the TIR script for batch matrix multiplication. It includes methods for validating dimensions, applying bias, and converting data types.
  • The BatchMatMulSelector class is responsible for selecting the appropriate TIR script emitter based on the provided layout and propagation parameters.
  • The select_implementation function has been updated to use the new BatchMatMulSelector class.

Changes in other files:

  • A new notify job has been added to the CI workflow in .github/workflows/ci.yml. This job runs when previous jobs fail and prints a message indicating that the jobs have failed but no email will be sent.
  • In bitblas/ops/impl/__init__.py, a noqa: F401 comment has been added to the import statement for tir_interleave_weight. This prevents linters from flagging the imported but unused tir_interleave_weight as an error.
  • The file bitblas/ops/impl/base.py has been created to provide two abstract base classes TIRScriptEmitter and TIRScriptSelector for TIR script emitters and selectors, respectively.

@LeiWang1999 LeiWang1999 changed the title [CI] Refactor the notify in CI [CI] Edit the notify setting in our CI Jul 5, 2024
@LeiWang1999 LeiWang1999 merged commit 60caba6 into microsoft:main Jul 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant