Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Refactor scripts based on our new directory structure #69

Merged
merged 13 commits into from
Jul 4, 2024

Conversation

LeiWang1999
Copy link
Contributor

@LeiWang1999 LeiWang1999 commented Jul 3, 2024

Ref to the pull request #68 , our file structure has been changed, the scripts and tvm related import should be modified as well.

TODO Items:

  • Installation Scripts
  • Distribution Scripts
  • TVM Imports

This pull request includes changes to the bitblas module, primarily focused on modifying the import paths for the tvm module and refactoring the bitblas/__init__.py and bitblas/ops/general_matmul.py files. The changes are aimed at improving the structure and clarity of the code.

Changes to import paths:

  • The import paths for the tvm module have been changed from import tvm to from bitblas import tvm in multiple files. This change suggests a restructuring of the module's dependencies and is aimed at improving the clarity and maintainability of the code. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]

Changes to bitblas/__init__.py:

  • The path for the tvm module in the install_tvm_path and develop_tvm_path variables has been updated. The changes suggest a restructuring of the module's directory.
  • A new line has been added after the import of the try_inline_contiguous_spatial function. This change is likely meant to improve the readability of the code.

Changes to bitblas/ops/general_matmul.py:

  • The warmup method in the bitblas/module/__init__.py file has been refactored. The changes include reordering of the code and changes to the arguments passed to the self.bitblas_matmul.lib.call method. These changes are likely aimed at improving the efficiency and readability of the code.
  • The __legalize_propagate method has been updated to handle a new case where propagate_b is NonTransform. This change is likely meant to improve the functionality of the method.

@LeiWang1999 LeiWang1999 marked this pull request as ready for review July 4, 2024 04:50
@LeiWang1999 LeiWang1999 merged commit f4e15a5 into microsoft:main Jul 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant