Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on refining the type conversions and adjusting the precision in the testing function. The changes are aimed at improving the efficiency and accuracy of the code.
Here are the key changes:
Type conversion refinement:
python/bitblas/quantization/quantization.py
: In the function_tir_u8_to_f8_e4m3_to_f16
, the type of the shift operation has been changed fromint16
touint16
. Also, the calculation ofs_f16
ande_f16
has been modified to use bitwise operations.Precision adjustment:
testing/python/operators/test_general_matmul_fp8.py
: In the functionmap_torch_type
, the relative and absolute tolerances for thetorch.testing.assert_close
function have been increased from1e-2
to1e-1
to adjust the precision of the test.