Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs for Fixed Assets and Fixed Asset Locations #24169

Merged
merged 7 commits into from
Nov 20, 2023

Conversation

kb-dynaway
Copy link
Contributor

For one of the community project related to the PowerApp it is needed to have a APIs for Fixed Assets and Fixed Asset Locations.

Those APIs are needed in standard API collection since. It will also allow more interact with the date inside Business Central (for example create Power Automate flows based on Fixed Assets)

@kb-dynaway
Copy link
Contributor Author

@microsoft-github-policy-service agree

@JesperSchulz
Copy link
Contributor

Hey @kb-dynaway, we seem to be missing some E2E tests to be able to process this PR. Is that something you can add? Would love to process this PR for you :-)

@kb-dynaway
Copy link
Contributor Author

Hi @JesperSchulz appologise for that. To be honest I have it on my list and need to back to it. I just need to know how to deal with it which is the biggest stopper from my side.

I will try to finish it during the weekend.

@JesperSchulz
Copy link
Contributor

No stress... Was just checking if you still had this one on your todo-list ;-)

@kb-dynaway
Copy link
Contributor Author

@JesperSchulz please check now, my brilliant colleague @barud-dyna added the tests :) let us know if all works now.

Copy link
Contributor

@onbuyuka onbuyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Nov 7, 2023
@kb-dynaway
Copy link
Contributor Author

@JesperSchulz any news about this one? Do you know when we can get it to the product?

@JesperSchulz
Copy link
Contributor

@kb-dynaway, I just checked. We've created an internal PR to get this processed, but it seems some tests failed. @onbuyuka will be able to give you the details 😊

@JesperSchulz JesperSchulz added the ships-in-future-update Fix ships in a future update label Nov 17, 2023
@JesperSchulz
Copy link
Contributor

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 13996.

@onbuyuka
Copy link
Contributor

Tests you added were failing so we had to make some changes. Also we have included page parts I mentioned in the review (employee, FA location) in order to enable deep inserts. That required some other changes like new fields and upgrade code because we need to keep our APIs compliant with Dataverse VTs (only GUID navigational properties are allowed).

Long story short, changes are merged to the main branch and I have just backported them to 23.x, meaning it will be available with version 23.2.

@JesperSchulz
Copy link
Contributor

Availability update: We will publish a fix for this issue in the next update for release 23.

Build ID to track: 14010.

@JesperSchulz JesperSchulz reopened this Nov 20, 2023
@JesperSchulz JesperSchulz merged commit 2b7ad5d into microsoft:main Nov 20, 2023
4 of 10 checks passed
aholstrup1 pushed a commit to aholstrup1/ALAppExtensions that referenced this pull request Sep 6, 2024
For one of the community project related to the PowerApp it is needed to
have a APIs for Fixed Assets and Fixed Asset Locations.

Those APIs are needed in standard API collection since. It will also
allow more interact with the date inside Business Central (for example
create Power Automate flows based on Fixed Assets)

---------

Co-authored-by: Bartosz Rudzinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processing-PR The PR is currently being reviewed ships-in-future-update Fix ships in a future update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants