GP Updates - September 2024 (#27265)

This PR contains the following enhancements to the GP migrations. - Hide the Run Data Upgrade Now action when the One Step Migration is enabled. - Remove the dependency on Sales and Inventory Forecast app. - Obsolete the old GP pages around the staging table data. Fixes #26487 Fixes [AB#550763](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/550763) --------- Co-authored-by: jaymckinney <[email protected]>
microsoft · Sep 30, 2024 · 1a13eb2 · 1a13eb2
1 parent bebe953
commit 1a13eb2
Show file tree

Hide file tree

Showing 23 changed files with 118 additions and 928 deletions.
diff --git a/Apps/W1/HybridGP/app/Permissions/HybridGPEdit.PermissionSet.al b/Apps/W1/HybridGP/app/Permissions/HybridGPEdit.PermissionSet.al
@@ -49,7 +49,11 @@ permissionset 4031 "HybridGP - Edit"
                     tabledata "GPSOPTrxHist" = IMD,
                     tabledata "GPSOPUserDefinedWorkHist" = IMD,
                     tabledata "GPSOPWorkflowWorkHist" = IMD,
+#if not CLEAN26
+#pragma warning disable AL0432
                     tabledata "GPForecastTemp" = IMD,
+#pragma warning restore AL0432
+#endif
                     tabledata "GP Item" = IMD,
                     tabledata "GP Item Location" = IMD,
                     tabledata "GP Item Transactions" = IMD,

diff --git a/Apps/W1/HybridGP/app/Permissions/HybridGPObjects.PermissionSet.al b/Apps/W1/HybridGP/app/Permissions/HybridGPObjects.PermissionSet.al
@@ -10,17 +10,12 @@ permissionset 4029 "HybridGP - Objects"
                     codeunit "Hybrid Handle GP Upgrade Error" = X,
                     codeunit "Hybrid GP Management" = X,
                     codeunit "Hybrid GP Wizard" = X,
-                    page "GP Account" = X,
                     table "GP Account" = X,
                     codeunit "GP Account Migrator" = X,
-                    page "GP Fiscal Periods" = X,
                     table "GP Fiscal Periods" = X,
-                    page "GP GLTransactions" = X,
                     table "GP GLTransactions" = X,
-                    page "GP Customer" = X,
                     table "GP Customer" = X,
                     codeunit "GP Customer Migrator" = X,
-                    page "GP Customer Transactions" = X,
                     table "GP Customer Transactions" = X,
                     table "GPIVBinQtyTransferHist" = X,
                     table "GPIVDistributionHist" = X,
@@ -58,12 +53,9 @@ permissionset 4029 "HybridGP - Objects"
                     table "GPSOPTrxHist" = X,
                     table "GPSOPUserDefinedWorkHist" = X,
                     table "GPSOPWorkflowWorkHist" = X,
-                    codeunit "GPForecastHandler" = X,
                     codeunit "GP PO Migrator" = X,
                     codeunit "GP Populate Hist. Tables" = X,
-                    table "GPForecastTemp" = X,
                     codeunit "Install GP SmartLists" = X,
-                    page "GP Item" = X,
                     table "GP Item" = X,
                     table "GP Item Location" = X,
                     codeunit "GP Item Migrator" = X,
@@ -74,7 +66,6 @@ permissionset 4029 "HybridGP - Objects"
                     table "GP Codes" = X,
                     table "GP Configuration" = X,
                     table "GP Payment Terms" = X,
-                    page "GP Posting Accounts" = X,
                     table "GP Posting Accounts" = X,
                     table "GP Segments" = X,
                     Codeunit "Helper Functions" = X,
@@ -83,10 +74,8 @@ permissionset 4029 "HybridGP - Objects"
                     table "GP Checkbook MSTR" = X,
                     table "GP Checkbook Transactions" = X,
                     codeunit "GP Intelligent Cloud Upgrade" = X,
-                    page "GP Vendor" = X,
                     table "GP Vendor" = X,
                     codeunit "GP Vendor Migrator" = X,
-                    page "GP Vendor Transactions" = X,
                     table "GP Vendor Transactions" = X,
                     page "GP Migration Settings List" = X,
                     page "Hybrid GP Errors Factbox" = X,
@@ -141,7 +130,25 @@ permissionset 4029 "HybridGP - Objects"
                     codeunit "GP Migration Error Handler" = X,
                     page "GP Migration Error Overview" = X,
 #if not CLEAN24
+#pragma warning disable AL0432
                     page "Hybrid GP Errors Overview Fb" = X,
+#pragma warning restore AL0432
+#endif
+
+#if not CLEAN26
+#pragma warning disable AL0432
+                    page "GP Account" = X,
+                    page "GP Fiscal Periods" = X,
+                    page "GP GLTransactions" = X,
+                    page "GP Customer" = X,
+                    page "GP Customer Transactions" = X,
+                    codeunit "GPForecastHandler" = X,
+                    table "GPForecastTemp" = X,
+                    page "GP Item" = X,
+                    page "GP Posting Accounts" = X,
+                    page "GP Vendor" = X,
+                    page "GP Vendor Transactions" = X,
+#pragma warning restore AL0432
 #endif
                     table "GP Migration Error Overview" = X,
                     table "GP Upgrade Settings" = X,

diff --git a/Apps/W1/HybridGP/app/Permissions/HybridGPRead.PermissionSet.al b/Apps/W1/HybridGP/app/Permissions/HybridGPRead.PermissionSet.al
@@ -49,7 +49,11 @@ permissionset 4032 "HybridGP - Read"
                     tabledata "GPSOPTrxHist" = R,
                     tabledata "GPSOPUserDefinedWorkHist" = R,
                     tabledata "GPSOPWorkflowWorkHist" = R,
+#if not CLEAN26
+#pragma warning disable AL0432
                     tabledata "GPForecastTemp" = R,
+#pragma warning restore AL0432
+#endif
                     tabledata "GP Item" = R,
                     tabledata "GP Item Location" = R,
                     tabledata "GP Item Transactions" = R,

diff --git a/Apps/W1/HybridGP/app/Permissions/INTELLIGENTCLOUDHGP.PermissionSetExt.al b/Apps/W1/HybridGP/app/Permissions/INTELLIGENTCLOUDHGP.PermissionSetExt.al
@@ -8,7 +8,11 @@ permissionsetextension 4028 "INTELLIGENT CLOUD - HGP" extends "INTELLIGENT CLOUD
                   tabledata GPPOPTaxHist = RIMD,
                   tabledata GPSOPTrxHist = RIMD,
                   tabledata GPSOPProcessHoldWorkHist = RIMD,
+#if not CLEAN26
+#pragma warning disable AL0432
                   tabledata GPForecastTemp = RIMD,
+#pragma warning restore AL0432
+#endif
                   tabledata GPIVTrxAmountsHist = RIMD,
                   tabledata GPSOPWorkflowWorkHist = RIMD,
                   tabledata "GP GLTransactions" = RIMD,

diff --git a/Apps/W1/HybridGP/app/Permissions/d365basicHGP.permissionsetext.al b/Apps/W1/HybridGP/app/Permissions/d365basicHGP.permissionsetext.al
@@ -8,7 +8,11 @@ permissionsetextension 4025 "D365 BASIC - HGP" extends "D365 BASIC"
                   tabledata GPPOPTaxHist = RIMD,
                   tabledata GPSOPTrxHist = RIMD,
                   tabledata GPSOPProcessHoldWorkHist = RIMD,
+#if not CLEAN26
+#pragma warning disable AL0432
                   tabledata GPForecastTemp = RIMD,
+#pragma warning restore AL0432
+#endif
                   tabledata GPIVTrxAmountsHist = RIMD,
                   tabledata GPSOPWorkflowWorkHist = RIMD,
                   tabledata "GP GLTransactions" = RIMD,

diff --git a/Apps/W1/HybridGP/app/Permissions/d365teammemberHGP.permissionsetext.al b/Apps/W1/HybridGP/app/Permissions/d365teammemberHGP.permissionsetext.al
@@ -8,7 +8,11 @@ permissionsetextension 4027 "D365 TEAM MEMBER - HGP" extends "D365 TEAM MEMBER"
                   tabledata GPPOPTaxHist = RIMD,
                   tabledata GPSOPTrxHist = RIMD,
                   tabledata GPSOPProcessHoldWorkHist = RIMD,
+#if not CLEAN26
+#pragma warning disable AL0432
                   tabledata GPForecastTemp = RIMD,
+#pragma warning restore AL0432
+#endif
                   tabledata GPIVTrxAmountsHist = RIMD,
                   tabledata GPSOPWorkflowWorkHist = RIMD,
                   tabledata "GP GLTransactions" = RIMD,

diff --git a/Apps/W1/HybridGP/app/app.json b/Apps/W1/HybridGP/app/app.json
@@ -24,12 +24,6 @@
       "publisher": "Microsoft",
       "version": "26.0.0.0"
     },
-    {
-      "id": "c526b3e9-b8ca-4683-81ba-fcd5f6b1472a",
-      "name": "Sales and Inventory Forecast",
-      "publisher": "Microsoft",
-      "version": "26.0.0.0"
-    },
     {
       "id": "ea130081-c669-460f-a5f4-5dde14f03131",
       "name": "Statistical Accounts",

diff --git a/Apps/W1/HybridGP/app/src/Migration/Accounts/GPAccount.page.al b/Apps/W1/HybridGP/app/src/Migration/Accounts/GPAccount.page.al
@@ -1,3 +1,4 @@
+#if not CLEAN26
 namespace Microsoft.DataMigration.GP;
 
 page 4090 "GP Account"
@@ -8,6 +9,10 @@ page 4090 "GP Account"
     InsertAllowed = false;
     Caption = 'Account Table';
     PromotedActionCategories = 'Related Entities';
+    UsageCategory = None;
+    ObsoleteState = Pending;
+    ObsoleteReason = 'Removing the GP staging table pages because they cause confusion and should not be used.';
+    ObsoleteTag = '26.0';
 
     layout
     {
@@ -74,3 +79,4 @@ page 4090 "GP Account"
         }
     }
 }
+#endif
diff --git a/Apps/W1/HybridGP/app/src/Migration/Accounts/GPFiscalPeriods.page.al b/Apps/W1/HybridGP/app/src/Migration/Accounts/GPFiscalPeriods.page.al
@@ -1,3 +1,4 @@
+#if not CLEAN26
 namespace Microsoft.DataMigration.GP;
 
 page 4092 "GP Fiscal Periods"
@@ -8,6 +9,10 @@ page 4092 "GP Fiscal Periods"
     InsertAllowed = false;
     Caption = 'Fiscal Periods Table';
     PromotedActionCategories = 'Related Entities';
+    UsageCategory = None;
+    ObsoleteState = Pending;
+    ObsoleteReason = 'Removing the GP staging table pages because they cause confusion and should not be used.';
+    ObsoleteTag = '26.0';
 
     layout
     {
@@ -39,3 +44,4 @@ page 4092 "GP Fiscal Periods"
         }
     }
 }
+#endif
diff --git a/Apps/W1/HybridGP/app/src/Migration/Accounts/GPGLTransactions.page.al b/Apps/W1/HybridGP/app/src/Migration/Accounts/GPGLTransactions.page.al
@@ -1,10 +1,15 @@
+#if not CLEAN26
 namespace Microsoft.DataMigration.GP;
 
 page 4091 "GP GLTransactions"
 {
     PageType = List;
     SourceTable = "GP GLTransactions";
     Caption = 'General Ledger Transactions';
+    UsageCategory = None;
+    ObsoleteState = Pending;
+    ObsoleteReason = 'Removing the GP staging table pages because they cause confusion and should not be used.';
+    ObsoleteTag = '26.0';
 
     layout
     {
@@ -115,3 +120,4 @@ page 4091 "GP GLTransactions"
         }
     }
 }
+#endif
diff --git a/Apps/W1/HybridGP/app/src/Migration/Customers/GPCustomer.page.al b/Apps/W1/HybridGP/app/src/Migration/Customers/GPCustomer.page.al
@@ -1,3 +1,4 @@
+#if not CLEAN26
 namespace Microsoft.DataMigration.GP;
 
 page 4093 "GP Customer"
@@ -8,6 +9,10 @@ page 4093 "GP Customer"
     InsertAllowed = false;
     Caption = 'Customer Table';
     PromotedActionCategories = 'Related Entities';
+    UsageCategory = None;
+    ObsoleteState = Pending;
+    ObsoleteReason = 'Removing the GP staging table pages because they cause confusion and should not be used.';
+    ObsoleteTag = '26.0';
 
     layout
     {
@@ -130,3 +135,4 @@ page 4093 "GP Customer"
         }
     }
 }
+#endif
diff --git a/Apps/W1/HybridGP/app/src/Migration/Customers/GPCustomerTransactions.page.al b/Apps/W1/HybridGP/app/src/Migration/Customers/GPCustomerTransactions.page.al
@@ -1,13 +1,16 @@
+#if not CLEAN26
 namespace Microsoft.DataMigration.GP;
 
 page 4094 "GP Customer Transactions"
 {
     Caption = 'GP Customer Transactions';
-    AdditionalSearchTerms = 'staging';
     PageType = List;
     SourceTable = "GP Customer Transactions";
     ApplicationArea = All;
-    UsageCategory = Lists;
+    UsageCategory = None;
+    ObsoleteState = Pending;
+    ObsoleteReason = 'Removing the GP staging table pages because they cause confusion and should not be used.';
+    ObsoleteTag = '26.0';
 
     layout
     {
@@ -97,4 +100,5 @@ page 4094 "GP Customer Transactions"
             }
         }
     }
-}
+}
+#endif