This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjaguarpaw
suggested changes
Dec 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks excellent
msdmkats
suggested changes
Dec 24, 2019
msdmkats
reviewed
Dec 24, 2019
msdmkats
approved these changes
Dec 24, 2019
/AzurePipelines help |
Supported commands
See additional documentation. |
tomjaguarpaw
reviewed
Jan 3, 2020
There is $null, which you would need to check using “$x -eq $null”. It’s a little tricky as PowerShell does so much null-conversion anyway, so there’s an argument for the sentinel too.
|
tomjaguarpaw
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this. It seems like squash merge might be most appropriate but I'll leave it up to you.
mikhailnikolaev
force-pushed
the
miniko/oom_checking
branch
from
January 13, 2020 13:16
cddde9d
to
81a607d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global runner takes additional parameter that defines maximum RAM size that the runner can consume. If test takes more, then it will be killed. Also, guaranteed out of memory checking is performed the same way as guaranteed timeout checking.
This PR solves the issue #172.