Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readgpio_s3.py #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update readgpio_s3.py #97

wants to merge 1 commit into from

Conversation

synco
Copy link

@synco synco commented Jan 31, 2024

To be consistent with the processor example I'd expect this... not sure about the knock-on effects.

To be consistent with the processor example I'd expect this... not sure about the knock-on effects.
@wnienhaus
Copy link
Collaborator

Actually esp32s2 is the correct value even for the ESP32-S3, because it specifies the instruction set of the ULP, not the overall device. The ESP32-S2 and ESP32-S3 have an identical ULP (at least the FSM ULP) which is why we simply called it all "esp32s2".

I can see how that can be confusing though. The README refers to this: https://github.com/micropython/micropython-esp32-ulp#id1, but maybe it could be easier, if we supported esp32s3 as a cpu type and simply treat it the same as esp32s2 internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants