[150] Add a GitHub Action to run CI for PR's and pushes. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emily-Jiang
reviewed
Jan 22, 2024
pom.xml
Outdated
| <parent> | ||
| <groupId>org.eclipse.microprofile</groupId> | ||
| <artifactId>microprofile-parent</artifactId> | ||
| <version>2.6</version> | ||
| </parent> | ||
| <version>3.1</version> |
There was a problem hiding this comment.
Suggested change
| <version>3.1</version> | |
| <version>3.2</version> |
There was a problem hiding this comment.
I approved the PR #368 . I think we can merge that one first and then you can rebase. What do you think?
There was a problem hiding this comment.
+1, once that is merged I'll get this one updated and it will only contain the workflow file.
There was a problem hiding this comment.
Thank you! I've updated this commit and made it a PR.
Signed-off-by: James R. Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #150
This should likely be merged after #368