Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not merge [issue #110] Wireformat checks property as object, not array, keyed… #156

Closed
wants to merge 1 commit into from

Conversation

xstefank
Copy link
Member

… by check name

issue #110

…array, keyed by check name

Signed-off-by: xstefank <[email protected]>
Copy link
Contributor

@antoinesd antoinesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether this makes sense any more. I tried and found out health check names do not need to be unique.

0  
data  
stop true
name "serviceA"
state "UP"
1  
data  
lifetime 365
name "serviceA"
state "UP"
outcome "UP"

@Emily-Jiang
Copy link
Member

I suggest not to do this change as I don't see much benefit to introduce this change at all but cause more issues.

@xstefank
Copy link
Member Author

@Emily-Jiang just for completeness - the unique names have been discussed in #34

@Emily-Jiang
Copy link
Member

I have added a comment on that issue. Unless there is a business reason, I prefer not to do this as it will break old apps for no strong reason.

@antoinesd
Copy link
Contributor

@Emily-Jiang one of the idea is to enforce uniqueness of check's name and to align on other practice around. Like it was discussed in #110, it is still possible to keep the old format for backward compatibility (with a flag for instance)

@Emily-Jiang
Copy link
Member

I don't see any real benefit brought by this change except introducing breaking changes.

@Emily-Jiang Emily-Jiang changed the title [issue #110] Wireformat checks property as object, not array, keyed… Do not merge [issue #110] Wireformat checks property as object, not array, keyed… Apr 26, 2019
@xstefank
Copy link
Member Author

Closing this PR. We will try this feature in the implementations first.

@xstefank xstefank closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants