Demonstrate bug: span hierarchy is incorrect when client call is nested within an internal span #510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the very last commit is relevant for the bug itself, I needed to merge in a couple other pending changes though to be able to demonstrate this.
First, I thought that this might be an issue with incorrect tracing implementation of either the
@NewSpan
or the declarative HTTP client, but then I created a similar test for Jaeger tracing, and the exact same problem is present there.This is how far I got in trying to figure out where it goes wrong:
Mono.toFuture()
in the controller method the initialization of the client filter chain is triggered and for some reason it uses the current span context (which is the top-level server span) instead of the internal span.@NewSpan
starts with the downstream call instead of theMono.just
, then the correct span context is captured as the parent of the client span of the outgoing call.If we return a
Mono
in the controller method instead of converting it toCompletableFuture
the span hierarchy is captured correctly. However, when using micronaut-graphql integration we need to returnCompletableFuture
-s.