Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code for Micronaut Framework 5 and document breaking changes. #988

Draft
wants to merge 1 commit into
base: 6.0.x
Choose a base branch
from

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Mar 15, 2024

closes #970

@wetted wetted added the type: breaking Introduces a breaking change label Mar 15, 2024
@wetted wetted self-assigned this Mar 15, 2024
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wetted
Copy link
Contributor Author

wetted commented Mar 15, 2024

ping @dstepanov

io.micronaut.configuration.kafka.annotation.ErrorStrategyValue.NONE is still in the code. It was added as a deprecated enum on #441 as part of a fix for #372.

I didn't remove this yet because it's still used for code in the module and it's not clear to me how to deal with it. Please advise, or contribute as appropriate. This PR is meant to remove all deprecated code for Micronaut Framework 5.

@sdelamo sdelamo changed the base branch from 5.4.x to 6.0.x April 11, 2024 11:44
@wetted wetted removed their assignment Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Introduces a breaking change
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Del @Deprecated Kafka
2 participants