Add native image support for Hazelcast instrumentation #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
reviewed
Nov 7, 2024
...e/src/main/resources/META-INF/native-image/io.micrometer/micrometer-core/reflect-config.json
Show resolved
Hide resolved
shakuzen
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Looks good to me. Do you think there's any issue merging this for 1.12.x so we can resolve the issue in patch releases for Hazelcast users?
We should probably think about adding some native image testing if we're intending to support it as a feature, but I think we can consider/work on that in a separate pull request from this.
@shakuzen No, I switched the base branch to |
shakuzen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to add native image support for Hazelcast.
Closes gh-5604