Support for meters with same names but different tag keys in prometheus registry #2653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an idea how to resolve this issue #877
and raising this PR to discuss it.
The PR has a basic implementation + some simple tests to verify it works and makes sense in general.
I wanted to make sure that the solution makes sense first before going the full path and spending hours or days on making it bullet-proof and efficient. So any input is welcome.
So what this fix does:
MicrometerCollector
is changed to store tag keys dynamically like it does for tag values now, it can return tag keys and values in samples without any issue and prometheus will be able to parse it correctly.What I did:
MicrometerCollector
to store the holders instead of tag values.MicrometerCollector
to get tag keys from the holders.