Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte-system-info #1049

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ npm-debug.log
.DS_Store
.idea
microjs.com.iml
package-lock.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only change data.js when adding a library. Please do not change .gitignore.

8 changes: 8 additions & 0 deletions data.js
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,14 @@ module.exports = [
url: "https://github.com/daniellmb/aop.js",
source: "https://raw.githubusercontent.com/daniellmb/aop.js/master/aop.js"
},
{
name: "svelte-system-info",
github: "rozek/svelte-system-info",
tags: ["browser-detection", "os-detection"],
description: "determines name and version of underlying browser and operating system (not only for Svelte)",
url: "https://github.com/rozek/svelte-system-info",
source: "https://raw.githubusercontent.com/rozek/svelte-system-info/main/src/svelte-system-info.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the readme - emphasis on "ready-to-use", which means you should not link to a TypeScript source file:

The 'source' attribute must point to a single-file, or an array of files that can be concatenated to form your complete library in a ready-to-use form. The 'source' must not be minified (see below)

},
{
name: "di.js",
tags: ["dependency", "injection", "di"],
Expand Down