adds cart-localstorage #1032
Merged
adds cart-localstorage #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pineapplemachine
requested changes
Nov 5, 2021
There was a problem hiding this comment.
The repository does not have a license file. ISC license is named in package.json, but I wouldn't go off of that alone. Please note the microjs readme's rules about licenses and update your repository with clearer open-source license information, such as by adding an ISC license text file to the root repository directory.
|
I noticed my PR from 2020 is still open and I feel a bit embarrassed it's the oldest here... 😅 I've added the missing license file to hopefully move things along. Can you check if anything else is needed so we can merge it? Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include this tiny e-commerce shopping cart lib. to the framework.