Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dejavu and nominatim backends, added logging #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thuryn
Copy link

@thuryn thuryn commented Apr 16, 2023

This UnifiedNlp reconstruction has been made to solve problem with backends (their mortality). The whole work is not finished, but it works fine on my phone and I'm happy to use UnifiedNlp again. So I want to share my work with somebody, who wants it. Not all changes is not comfortable for the author, so that's why I made this PR to review it. Yes many classes could be deleted now, and some parts is hardwritten (intents for settings screen), but any way and again - I'm glad it works after many hours.

Installation is tricky - the final solution should be probably accomplished by installation app first - where user confirm all requested permissions and then install the real UnifiedNlp on top of the installation app to get the real providers. I did it with updated app (on top of Magisk module) and Pepmission manager X app.

Main changes/features:

  1. added module for UnifiedNlp application (app), for nominatim (app-nominatim) and dejavu (app-dejavu) backends
  2. app-dejavu - cell network scanning rewritten to solve the problem with no cell id (the new API provides cell id just for registered cell)
  3. added settings screen into dejavu backend - you can clear the DB and see number of rows. Maybe I add the import/export function from wifi backend.
  4. added logging into file (not finished)

@IzzySoft
Copy link

I did it with updated app (on top of Magisk module)

Just wondering: which Magisk module are you referring to here? The microG installer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants