Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMS Maps: Optimize the phenomenon of Uber route drift. #2608

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

DaVinci9196
Copy link
Contributor

When using Uber, I found that the route information that appeared would drift when I moved the map. I am not sure if it is due to the map, so I will not calculate the route to display during the movement.

@mar-v-in mar-v-in changed the title Optimize the phenomenon of Uber route drift. HMS Maps: Optimize the phenomenon of Uber route drift. Nov 10, 2024
@mar-v-in mar-v-in added this to the 0.3.5 milestone Nov 11, 2024
@DaVinci9196 DaVinci9196 reopened this Nov 12, 2024
@mar-v-in mar-v-in merged commit 56af897 into microg:master Nov 16, 2024
1 check passed
@DaVinci9196 DaVinci9196 deleted the fix_hms_maps_error branch November 19, 2024 01:27
@yu895923549
Copy link

@DaVinci9196 It will caused a NullPointException when map destroyed.
when camera move, will postDelay a controlLayerRun, and map onDestroy will set mapView to null, when and it finally crashed on refreshContainerLayer caused you use mapView!!

java.lang.NullPointerException
at org.microg.gms.maps.hms.GoogleMapImpl.refreshContainerLayer(GoogleMapImpl.java:802)
at org.microg.gms.maps.hms.GoogleMapImpl.controlLayerRun$lambda$0(GoogleMapImpl.java:88)
at org.microg.gms.maps.hms.GoogleMapImpl.$r8$lambda$pYOiElsK2rOoMV9WyKMIWQBHR4E(GoogleMapImpl.java:0)
at org.microg.gms.maps.hms.GoogleMapImpl$$ExternalSyntheticLambda9.run(GoogleMapImpl.java:2)
at android.os.Handler.handleCallback(Handler.java:966)
at android.os.Handler.dispatchMessage(Handler.java:110)
at android.os.Looper.loopOnce(Looper.java:205)
at android.os.Looper.loop(Looper.java:293)
at android.app.ActivityThread.loopProcess(ActivityThread.java:9998)
at android.app.ActivityThread.main(ActivityThread.java:9987)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:586)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1240)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants