Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AssetModuleService #2506

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

DaVinci9196
Copy link
Contributor

The three applications were tested and can be downloaded and installed normally through the service.
e.g. com.wb.goog.mkx , com.gameloft.android.ANMP.GloftDYHM , jp.konami.pesam

@mar-v-in mar-v-in added this to the 0.3.4 milestone Aug 27, 2024
…s necessary to send progress change broadcasts in real time, otherwise the progress bar will be stuck.
@DaVinci9196 DaVinci9196 mentioned this pull request Oct 12, 2024
11 tasks
@bobaoapae
Copy link

Hey, can this be released on some canary build? I was running waze on a device thwt don't have play services, and installed gms core but waze was unable to download some files that I think it's because of this missing implementation. I would love to test this.

@DaVinci9196
Copy link
Contributor Author

Hey, can this be released on some canary build? I was running waze on a device thwt don't have play services, and installed gms core but waze was unable to download some files that I think it's because of this missing implementation. I would love to test this.

If possible, you can first check whether this service is called. At present, we only found that the game will download resource files through this service.

… problem that some games cannot obtain sub-packaged downloaded content.
@mar-v-in
Copy link
Member

Device Sync is not related to Asset Modules, please put it in a separate pull request.

@mar-v-in mar-v-in modified the milestones: 0.3.4, 0.3.5 Nov 10, 2024
@DaVinci9196
Copy link
Contributor Author

For example, the resource data returned by League of Legends depends on the device synchronization request #2621.

Comment on lines +116 to +132
val notificationLayout = RemoteViews(context.packageName, R.layout.layout_download_notification)
notificationLayout.setTextViewText(
R.id.notification_title, context.getString(R.string.download_notification_attachment_file, appName)
)
notificationLayout.setTextViewText(
R.id.notification_text, context.getString(R.string.download_notification_tips)
)
notificationLayout.setProgressBar(R.id.progress_bar, 100, 0, false)
notificationLayout.setImageViewBitmap(R.id.app_icon, bitmap)
notificationLayout.setOnClickPendingIntent(R.id.cancel_button, cancelPendingIntent)

val notifyBuilder =
NotificationCompat.Builder(context, CHANNEL_ID).setSmallIcon(R.drawable.ic_app_foreground).setStyle(NotificationCompat.DecoratedCustomViewStyle())
.setCustomContentView(notificationLayout).setPriority(NotificationCompat.PRIORITY_LOW).setOngoing(true).setOnlyAlertOnce(true)
.setColor(ContextCompat.getColor(context, R.color.notification_color)).setColorized(true)
notifyBuilderMap[moduleName] = notifyBuilder
notificationLayoutMap[moduleName] = notificationLayout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you use a custom notification layout instead of a default with setContentTitle(), setContentText(), setProgress(), setLargeIcon() and addAction()? That should cover the same content but not require a custom view with custom styling, thus better compatible with various android versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants