Update application dependencies #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgarber623
commented
Apr 21, 2020
| require: rubocop-rspec | ||
| require: | ||
| - rubocop-rails | ||
| - rubocop-rspec |
There was a problem hiding this comment.
Rails cops were removed from RuboCop in version 0.72.
| @@ -15,17 +17,14 @@ AllCops: | |||
| - '.git/**/*' | |||
|
|
|||
| IndentationConsistency: | |||
| EnforcedStyle: 'rails' | |||
| EnforcedStyle: 'indented_internal_methods' | |||
There was a problem hiding this comment.
Another change in RuboCop version 0.72.
| html { 'MyText' } | ||
| base_url { 'MyText' } | ||
| save_html { false } | ||
| render_html_in_page { false } |
There was a problem hiding this comment.
Newer versions of RuboCop use this syntax.
|
@jgarber623 I no longer maintain these repos. Could ask @aaronpk et al to review your PRs and/or give you commit bit, please? I would hate to have you waiting around on me and me not showing up for you. |
jgarber623
requested review from
aaronpk
and removed request for
veganstraightedge
|
@veganstraightedge No worries, bud! Thanks for the head's up. I've tagged @aaronpk for a review. |
|
It's been four years, so… closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Opening this draft PR against thefix-apps-and-spec-errorsbranch (PR #65). Will update and/or create a new PR againstmasterwhen that PR is merged.This pull request updates the application's dependencies in a semi-conservative fashion. All non-pending specs pass and RuboCop reports only a single offense (in
spec/views/submissions/show.html.erb_spec.rb) that may be addressed later.Closes #59
Closes #60
Closes #61
Closes #62
Closes #63
Closes #64