Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to willnorris.com/go/microformats v1.1.0 #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

willnorris
Copy link
Collaborator

No description provided.

@willnorris
Copy link
Collaborator Author

I'm not sure who has access to this repo or to the heroku app at https://go.microformats.io. I have a test instance of the app running at https://gomfweb.herokuapp.com/.

Compare, for example the new image alt tag parsing: old vs new

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a cursory review these changes make sense to me (from a non-go expert perspective) without fully understanding if the details are correct or not. It seems like we are not adding any new dependencies (e.g. on any additional libraries or domains) so that's good at least. We need someone who is familiar with go language runtime/configuration to review this. Or at least someone who is able to merge, check the site, and then rollback if necessary, with the confidence that doing so would work to restore the current state.

@willnorris
Copy link
Collaborator Author

Since I also maintain the underlying microformats library, I'm happy to maintain this repo as well, if folks are okay with that. I'm also happy to handle go.microformats.io as well, again if folks are comfortable with that. The last time I had talked to @veganstraightedge, I think he mentioned that things had been handed over to @aaronpk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants