switch to pypi sdist #3356
Merged
switch to pypi sdist #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinqiang zhang <[email protected]>
Signed-off-by: jinqiang zhang <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: jinqiang zhang <[email protected]>
Signed-off-by: jinqiang zhang <[email protected]>
Signed-off-by: jinqiang zhang <[email protected]>
Signed-off-by: jinqiang zhang <[email protected]>
Signed-off-by: jinqiang zhang <[email protected]>
Signed-off-by: jinqiang zhang <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: jinqiang zhang <[email protected]>
This comment has been minimized.
This comment has been minimized.
| PYTHON_COMPAT=( python3_{9..11} ) | ||
|
|
||
| inherit distutils-r1 | ||
| inherit distutils-r1 pypi |
There was a problem hiding this comment.
同上，pypi.eclass下再定义 MY_P 是无用功
| PYTHON_COMPAT=( python3_{9..11} ) | ||
|
|
||
| inherit distutils-r1 | ||
| inherit distutils-r1 pypi |
There was a problem hiding this comment.
同上，pypi.eclass下再定义 MY_P 是无用功
| PYTHON_COMPAT=( python3_{9..11} ) | ||
|
|
||
| inherit distutils-r1 | ||
| inherit distutils-r1 pypi |
There was a problem hiding this comment.
只要用了pypi.eclass就没必要再定义 MY_P 了。因为pypi.eclass会自动根据PEP 625和PEP 440的规则进行normalize，- 在SRC和S里会自动变成下划线 _，再自己定义MY_P完全是跟没写一样
There was a problem hiding this comment.
原来如此, S="${WORKDIR}/${MY_P}" 也是不需要了吧
There was a problem hiding this comment.
原来如此,
S="${WORKDIR}/${MY_P}"也是不需要了吧
正是。上面也有说S也会normalize。
| @@ -5,13 +5,12 @@ EAPI=8 | |||
| DISTUTILS_USE_PEP517=setuptools | |||
| PYTHON_COMPAT=( python3_{9..11} ) | |||
|
|
|||
| inherit distutils-r1 | |||
| inherit distutils-r1 pypi | |||
There was a problem hiding this comment.
同上，pypi.eclass下再定义 MY_P 是无用功
| PYTHON_COMPAT=( python3_{9..11} ) | ||
|
|
||
| inherit distutils-r1 | ||
| inherit distutils-r1 pypi |
There was a problem hiding this comment.
同上，pypi.eclass下再定义 MY_P 是无用功
| PYTHON_COMPAT=( python3_{9..11} pypy3 ) | ||
|
|
||
| inherit distutils-r1 | ||
| inherit distutils-r1 pypi |
There was a problem hiding this comment.
和上面类似，pypi.eclass 会根据 PEP 440的规则把版本号也进行normalize，第12行的 MY_P 定义写了也等于没写
This comment has been minimized.
This comment has been minimized.
Signed-off-by: jinqiang zhang <[email protected]>
⚪
|
Universebenzene
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.