Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x11-misc/ly: add 0.6.0, drop 0.5.3 #3346

Merged
merged 1 commit into from
Jun 21, 2023
Merged

x11-misc/ly: add 0.6.0, drop 0.5.3 #3346

merged 1 commit into from
Jun 21, 2023

Conversation

Linerre
Copy link
Contributor

@Linerre Linerre commented Jun 17, 2023 •
edited
Loading

fix #3336

这个包有 git submodules, 所以用到了 git-r3 class。但是这样一来，pkgcheck 会认为 VisibleVcsPkg 1 。
如果去掉 KEYWORDS, 包会因为 missing keywords 被 mask, 对用户不友好。保留，则 pkgcheck 会有警示。

另，上游变成了 fairyglade/ly [^2] ，我在 ebuild 里加了个 OLD_HOST 指向旧的上游，方便区分，不知是否妥当。

Footnotes

  1. https://pkgcore.github.io/pkgcheck/man/pkgcheck.html#visiblevcspkg
    [^2]: https://github.com/fairyglade/ly ↩

@github-actions

This comment has been minimized.

Sign in to view
@liangyongxiang
Copy link
Collaborator

这两个上游的区别是?

@Linerre
Copy link
Contributor Author

Linerre commented Jun 17, 2023 •
edited
Loading

这两个上游的区别是?

哦，还是原作者，我没细看，我改一下

@github-actions

This comment has been minimized.

Sign in to view
@Linerre
Copy link
Contributor Author

Linerre commented Jun 17, 2023

pkgcheck checks passed but with something can be improved!

QA Results:

x11-misc/ly
  DoubleEmptyLine: version 0.6.0: ebuild has unneeded empty line on on line: 8

我删一下那个空行

@github-actions

This comment has been minimized.

Sign in to view
@liangyongxiang
Copy link
Collaborator

我觉得有pkgcheck警告是可以接受的

@liangyongxiang
Copy link
Collaborator

现在ok了吗？

@Linerre
Copy link
Contributor Author

Linerre commented Jun 20, 2023 •
edited
Loading

现在ok了吗？

只是有个 VisibleVcsPkg 的警告，其他没什么了

@st0nie
Copy link
Contributor

st0nie commented Jun 20, 2023 •
edited
Loading

如果这个 submodule 很少更新的话，是不是可以把这个 submodule 打个压缩包放到 SRC_URI 里面，这样的话就可以不用 git-r3 了

图片

可以看到，这些 submodule 的更新时间是 2 年前，我估计作者也不会经常更新了

@Linerre
Copy link
Contributor Author

Linerre commented Jun 20, 2023

如果这个 submodule 很少更新的话，是不是可以把这个 submodule 打个压缩包放到 SRC_URI 里面，这样的话就可以不用 git-r3 了

好主意，我晚些时候回去了试试

@github-actions
Copy link

✔️ pkgcheck checks passed

@Linerre Linerre marked this pull request as ready for review June 21, 2023 05:53
@liangyongxiang liangyongxiang merged commit 42c3b1d into microcai:master Jun 21, 2023
@Linerre Linerre deleted the ly branch June 21, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[nvchecker] x11-misc/ly can be bump to 0.6.0
3 participants
@Linerre @liangyongxiang @st0nie