Update line dash type, calculation, docs (#2)

microbit-foundation · Nov 28, 2024 · 48298e7 · 48298e7
1 parent 1fd433e
commit 48298e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/smoothie.d.ts b/smoothie.d.ts
@@ -11,9 +11,10 @@ export interface ITimeSeriesOptions {
 export interface ITimeSeriesPresentationOptions {
     strokeStyle?: string;
     /**
+     * As per https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/setLineDash
      * Only supported for charts using fixed axes and linear interpolation.
      */
-    lineDash?: [number, number];
+    lineDash?: number[];
     fillStyle?: string;
     lineWidth?: number;
     /**

diff --git a/smoothie.js b/smoothie.js
@@ -302,7 +302,7 @@
           this.lineDashOffset = Number((removedLineLength + this.lineDashOffset).toFixed(2));
 
           // Reset lineDashOffset to zero where possible.
-          const totalDashLength = lineDash[0] + lineDash[1];
+          const totalDashLength = lineDash.reduce((acc, curr) => acc + curr, 0);
           if (this.lineDashOffset % totalDashLength === 0) {
             this.lineDashOffset = 0;
           }