Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate simulator compass animation #1197

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

microbit-robert
Copy link
Collaborator

This must have regressed when we updated Chakra?

The following warning is logged when using the as prop, and is fixed by pass the icon as a child instead.
Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()

Copy link

@microbit-matt-hillsdon
Copy link
Collaborator

Well spotted!

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 9e9fb88 into main Nov 27, 2024
2 checks passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the compass-animation branch November 27, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants