Skip to content

Commit

Permalink
Enable explanatory dialogs for all languages. (#1004)
Browse files Browse the repository at this point in the history
These were disabled due to lack of translated text.
  • Loading branch information
microbit-matt-hillsdon authored Sep 27, 2022
1 parent 352a97f commit d7cd1ec
Showing 1 changed file with 1 addition and 28 deletions.
29 changes: 1 addition & 28 deletions src/project/project-actions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,6 @@ export class ProjectActions {
finalFocusRef: React.RefObject<HTMLButtonElement>
): Promise<boolean> {
const showConnectHelpSetting = this.settings.values.showConnectHelp;
// Temporarily hide for French language users.
if (this.settings.values.languageId !== "en") {
return true;
}
if (
!force &&
(!showConnectHelpSetting ||
Expand Down Expand Up @@ -631,12 +627,7 @@ export class ProjectActions {
const filename = `${this.project.name}-${MAIN_FILE}`;
saveAs(blob, filename);
const multipleFiles = this.project.files.length > 1;
if (
multipleFiles &&
this.settings.values.showMultipleFilesHelp &&
// Temporarily hide for French language users.
this.settings.values.languageId === "en"
) {
if (multipleFiles && this.settings.values.showMultipleFilesHelp) {
const choice = await this.dialogs.show<MultipleFilesChoice>(
(callback) => (
<MultipleFilesDialog
Expand Down Expand Up @@ -808,10 +799,6 @@ export class ProjectActions {
userAction: ConnectionAction,
finalFocusRef: React.RefObject<HTMLButtonElement>
) {
// Temporarily hide for French language users.
if (this.settings.values.languageId !== "en") {
return;
}
const choice = await this.dialogs.show<ConnectErrorChoice>((callback) => (
<NotFoundDialog callback={callback} finalFocusRef={finalFocusRef} />
));
Expand All @@ -824,12 +811,6 @@ export class ProjectActions {
finalFocusRef: React.RefObject<HTMLButtonElement>
) {
this.device.clearDevice();
// Temporarily hide for French language users.
if (this.settings.values.languageId !== "en") {
return this.actionFeedback.expectedError(
this.webusbErrorMessage(errorCode)
);
}
const choice = await this.dialogs.show<ConnectErrorChoice>((callback) => (
<FirmwareDialog callback={callback} finalFocusRef={finalFocusRef} />
));
Expand Down Expand Up @@ -960,10 +941,6 @@ export class ProjectActions {
finalFocusRef: React.RefObject<HTMLButtonElement>
) {
const showPostSaveHelpSetting = this.settings.values.showPostSaveHelp;
// Temporarily hide for French language users.
if (this.settings.values.languageId !== "en") {
return;
}
if (!showPostSaveHelpSetting) {
return;
}
Expand All @@ -990,10 +967,6 @@ export class ProjectActions {
finalFocusRef: React.RefObject<HTMLButtonElement>
) {
const showTransferHexHelpSetting = this.settings.values.showTransferHexHelp;
// Temporarily hide for French language users.
if (this.settings.values.languageId !== "en") {
return;
}
if (!forceTransferHexHelp && !showTransferHexHelpSetting) {
return;
}
Expand Down

0 comments on commit d7cd1ec

Please sign in to comment.