-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle local storage quota exceeding error #572
base: main
Are you sure you want to change the base?
Conversation
Preview build will be at |
Large data samples json that can be used for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the best way of triggering the dialog, but thought it was the easiest way to wrap all the set
actions in the store. Otherwise, I could write a wrapper to wrap state changes with a try-catch statement for catching quota exceeded errors, which I think is the more straightforward approach.
I'm unsure whether error handling is the right route, or at least unsure if it should be the primary way to address the issue. Other options we can consider:
I'd like to understand more about what folks who hit this error are actually doing and whether it makes any sense in a tool like CreateAI. |
The following error can occur when users import a large hex / large number of data samples, adding action / data samples, or when adding to their MakeCode project:
QuotaExceededError: Failed to execute 'setItem' on 'Storage': Setting the value of 'ml' exceeded the quota.
To mitigate the issue, I have proposed adding a dialog to handle the error.