Use individual GHA workflows to run tests (pytest) and check code format (black)
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is instead of using `NO_COLOR`, which did not seem to have any impact on Rich's use of color when run via GitHub Actions.
eecavanna
changed the title
pytest step into own GHA workflow and add workflow that runs black --checkpytest) and checking code format (black)
eecavanna
changed the title
pytest) and checking code format (black)pytest) and check code format (black)
eecavanna
deleted the
37-configure-gha-to-run-black-and-pytest-in-more-scenarios
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this branch, I extracted the test-related step from the existing GHA workflow and put it into a new GHA workflow, which runs in more scenarios (not just when we want to publish the package to PyPI).
I also created a third GHA workflow, which runs
blackin "check" mode; meaning, it does not actually reformat the code—it just checks its formatting and fails if the code does not conform.Finally, I updated a test that was failing only when run via GHA, so that it would pass there. The fix had to do with configuring Rich to not generated colorized output for that test.