Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to save changes of sample metadata when save button out of frame #84

Closed
simroux opened this issue Mar 25, 2024 · 2 comments · Fixed by #104
Closed

Unable to save changes of sample metadata when save button out of frame #84

simroux opened this issue Mar 25, 2024 · 2 comments · Fixed by #104
Assignees
Labels
beta-release Features and bug fixes that must be included in the first beta release bug Something isn't working

Comments

@simroux
Copy link
Collaborator

simroux commented Mar 25, 2024

Note: this is for after GSP/ ECR :-)

Just something I noticed on my phone, but I can replicate if I reduce the window size on my browser:

  • Open a sample and click on a metadata to modify, one with a long documentation text (e.g. broad-scale environmental context)
  • If the window is too small, the "Cancel" and "Save" buttons are not visible.
  • To make them visible, one can grad the frame up, but then the frame goes back down as soon as it's released, so I can't click on "save"

Possible solutions:

  • Make the frame "stick" when pulling it up
  • Put the "Cancel" and "Save" button above the doc ?

Screenshot below is to illustrate what happens when the window is too small (cancel and save out of frame)

image

@simroux simroux added the bug Something isn't working label Mar 25, 2024
@simroux simroux changed the title Unable to save change to sample metadata when out of fra,e Unable to save change to sample metadata when out of frame Mar 25, 2024
@simroux simroux changed the title Unable to save change to sample metadata when out of frame Unable to save changes of sample metadata when out of frame Mar 25, 2024
@simroux simroux changed the title Unable to save changes of sample metadata when out of frame Unable to save changes of sample metadata when save button out of frame Mar 25, 2024
@pkalita-lbl
Copy link
Collaborator

It looks like Ionic doesn't support scrollable sheet modals out of the box. This issue looks like it might have some good workarounds though: ionic-team/ionic-framework#24631

@simroux
Copy link
Collaborator Author

simroux commented Mar 25, 2024

Interesting. Note that this may also be an artifact of the Android App currently displaying as part of a browser rather as a "real" app. The documentation from Ionic indicates that sheets "can be swiped or dragged up to become full-screen", but in my case it never becomes full-screen. So anyway, I wanted to document this now while I still remembered it, but we should probably only try to fix it once we have a "proper" Android App display.

@pkalita-lbl pkalita-lbl added the beta-release Features and bug fixes that must be included in the first beta release label Mar 27, 2024
@pkalita-lbl pkalita-lbl moved this from Backlog to Todo in Field Notes Squad Board Apr 22, 2024
@pkalita-lbl pkalita-lbl self-assigned this Apr 24, 2024
@pkalita-lbl pkalita-lbl moved this from Todo to In Progress in Field Notes Squad Board Apr 24, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Field Notes Squad Board Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-release Features and bug fixes that must be included in the first beta release bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants