Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for the ESP32 C6 board #274

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

MadsRossen
Copy link
Contributor

This make it possible to set board target and build for the RISC-V board on the ESP32 C6 Board.

The C6 is not added to the CI workflow in this PR.

This make it possible to set board target and build for the RISC-V board on the ESP32 C6 Board.
@pablogs9
Copy link
Member

Thanks for the contribution @MadsRossen, is it possible for you to add it to the CI and to the README.md supported hardware?

@MadsRossen
Copy link
Contributor Author

Yes, i can do that, no problem :)

The CI for ESP C6 follow the CI for ESP C3 as they both use RISC-V
@MadsRossen
Copy link
Contributor Author

I did not take into account that the ESP-C6 is not supported by the idf V4.4, therefore it fails in the CI.

@pablogs9
Copy link
Member

Did you find any problem building this module in IDF 5+ locally?

I noticed that we already have support for IDFv5 in our CI, so I would be ok having a skip in the CI if C6 + IDFv4 is used

@MadsRossen
Copy link
Contributor Author

I did not have any problems with IDF 5+ building locally.

@pablogs9
Copy link
Member

pablogs9 commented Jan 28, 2025

Could you please add this skip to this PR? I guess that something like this will work:

  micro_ros_idf:
    runs-on: ubuntu-latest
    strategy:
      fail-fast: false
      matrix:
        idf_target: [esp32, esp32s2, esp32s3, esp32c3, esp32c6]
        idf_version: [ "espressif/idf:release-v4.4", "espressif/idf:release-v5.2" ]
        exclude:
          # Skip IDF v4 + ESP32C6 combination
          - idf_target: esp32c6
            idf_version: espressif/idf:release-v4.4

@pablogs9
Copy link
Member

Great, it works! Thanks a lot for the contribution @MadsRossen

@pablogs9
Copy link
Member

@mergify backport rolling humble

Copy link
Contributor

mergify bot commented Jan 29, 2025

backport rolling humble

✅ Backports have been created

@pablogs9 pablogs9 merged commit c5825cc into micro-ROS:jazzy Jan 29, 2025
10 checks passed
mergify bot pushed a commit that referenced this pull request Jan 29, 2025
* Support for the ESP32 C6 board
This make it possible to set board target and build for the RISC-V board on the ESP32 C6 Board.

* Add CI for ESP32 C6
The CI for ESP C6 follow the CI for ESP C3 as they both use RISC-V

* Add ESP32-C6 to  README

* Exclude the CI run for IDFv4.4 using esp32c6

(cherry picked from commit c5825cc)

# Conflicts:
#	.github/workflows/nightly.yml
mergify bot pushed a commit that referenced this pull request Jan 29, 2025
* Support for the ESP32 C6 board
This make it possible to set board target and build for the RISC-V board on the ESP32 C6 Board.

* Add CI for ESP32 C6
The CI for ESP C6 follow the CI for ESP C3 as they both use RISC-V

* Add ESP32-C6 to  README

* Exclude the CI run for IDFv4.4 using esp32c6

(cherry picked from commit c5825cc)

# Conflicts:
#	.github/workflows/nightly.yml
pablogs9 added a commit that referenced this pull request Jan 29, 2025
* Initial support for the ESP32 C6 board (#274)

* Support for the ESP32 C6 board
This make it possible to set board target and build for the RISC-V board on the ESP32 C6 Board.

* Add CI for ESP32 C6
The CI for ESP C6 follow the CI for ESP C3 as they both use RISC-V

* Add ESP32-C6 to  README

* Exclude the CI run for IDFv4.4 using esp32c6

(cherry picked from commit c5825cc)

# Conflicts:
#	.github/workflows/nightly.yml

* Update nightly.yml

---------

Co-authored-by: Mads Rossen <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
pablogs9 added a commit that referenced this pull request Jan 29, 2025
* Initial support for the ESP32 C6 board (#274)

* Support for the ESP32 C6 board
This make it possible to set board target and build for the RISC-V board on the ESP32 C6 Board.

* Add CI for ESP32 C6
The CI for ESP C6 follow the CI for ESP C3 as they both use RISC-V

* Add ESP32-C6 to  README

* Exclude the CI run for IDFv4.4 using esp32c6

(cherry picked from commit c5825cc)

# Conflicts:
#	.github/workflows/nightly.yml

* Update nightly.yml

---------

Co-authored-by: Mads Rossen <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants