Feature key value array #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bart Jimenez Vera <[email protected]>
bjv-capra
force-pushed
the
feature/key-value-array
branch
from
f42f85f to
b890dbd
Compare
ralph-lange
requested changes
May 3, 2022
micro_ros_diagnostic_updater/src/micro_ros_diagnostic_updater/micro_ros_diagnostic_updater.c
Outdated
Show resolved
Hide resolved
|
I guess micro_ros_diagnostic_msgs/.gitignore can be removed from this PR. |
Signed-off-by: Bart Jimenez Vera <[email protected]>
Signed-off-by: Bart Jimenez Vera <[email protected]>
Signed-off-by: Bart Jimenez Vera <[email protected]>
Signed-off-by: Bart Jimenez Vera <[email protected]>
|
I'll have to force push, as I deleted the commit where I bumped the version |
bjv-capra
force-pushed
the
feature/key-value-array
branch
from
5109056 to
ad9fd4e
Compare
|
This pr fixes #26 as well |
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
- Coverage 9.58% 8.53% -1.05%
=========================================
Files 27 33 +6
Lines 2149 2577 +428
Branches 305 291 -14
=========================================
+ Hits 206 220 +14
- Misses 1800 2272 +472
+ Partials 143 85 -58
Continue to review full report at Codecov.
|
ralph-lange
approved these changes
May 4, 2022
micro_ros_diagnostic_updater/example/example_processor_updater.c
Outdated
Show resolved
Hide resolved
micro_ros_diagnostic_updater/example/example_processor_updater.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Bart Jimenez Vera <[email protected]>
|
I'll do some testing before merging, to ensure I didn't miss anything :) |
Signed-off-by: Bart Jimenez Vera <[email protected]>
Signed-off-by: Bart Jimenez Vera <[email protected]>
|
Merging as it fails due to missing rolling packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to have multiple Key values per task, instead of a 1:1 case. An example case would be one task that iterates over multiple errors and needs to push them all at once.