Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate script once for Turbolinks5 #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yhirano55
Copy link

@yhirano55 yhirano55 commented Mar 19, 2018

With Turbolinks 5, if it doesn't add data-turbolinks-eval="false" to script tag, script is evaluated many times (each per pages loading). So I've fixed it.

@kreintjes
Copy link

Also seems to fix #223.

@michelson could you have a look at this PR or #224 please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants