Added a more thorough Usage example, and make skipPermissionRequests optional #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When I first looked at the repo, it wasn't clear that the permissions would be handled so easily. The example app has too many features, and so gives the impression that all that work is required to get it to work. The API is great, show it off!
I also changed some types for the configuration. The docs say that
skipPermissionRequests
defaults tofalse
, but actually it's a required option according to the typescript definition.Test Plan
I'm using this fork/branch in my own project - I tested the changes to
setRNConfiguration
and types on ios and android.On Android, I tested the changes by logging the value here:
And similarly on iOS