Skip to content

Empty union bitfield members #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/gen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1291,17 +1291,25 @@ fn gen_bitfield_method(ctx: &mut GenCtx, bindgen_name: &String,
}

fn gen_fullbitfield_method(ctx: &mut GenCtx, bindgen_name: &String,
field_type: &Type, bitfields: &Vec<(String, u32)>) -> ast::ImplItem {
field_type: &Type, bitfields: &[(String, u32)]) -> ast::ImplItem {
let field_type = cty_to_rs(ctx, field_type, false);
let mut args = vec!();
let mut unnamed: usize = 0;
for &(ref name, width) in bitfields.iter() {
let ident = if name.is_empty() {
unnamed += 1;
let dummy = format!("unnamed_bitfield{}", unnamed);
ctx.ext_cx.ident_of(&dummy)
} else {
ctx.ext_cx.ident_of(name)
};
args.push(ast::Arg {
ty: P(type_for_bitfield_width(ctx, width)),
pat: P(ast::Pat {
id: ast::DUMMY_NODE_ID,
node: ast::PatIdent(
ast::BindingMode::ByValue(ast::MutImmutable),
respan(ctx.span, ctx.ext_cx.ident_of(name)),
respan(ctx.span, ident),
None
),
span: ctx.span
Expand All @@ -1320,8 +1328,15 @@ fn gen_fullbitfield_method(ctx: &mut GenCtx, bindgen_name: &String,

let mut offset = 0;
let mut exprs = quote_expr!(&ctx.ext_cx, 0);
let mut unnamed: usize = 0;
for &(ref name, width) in bitfields.iter() {
let name_ident = ctx.ext_cx.ident_of(&name);
let name_ident = if name.is_empty() {
unnamed += 1;
let dummy = format!("unnamed_bitfield{}", unnamed);
ctx.ext_cx.ident_of(&dummy)
} else {
ctx.ext_cx.ident_of(name)
};
exprs = quote_expr!(&ctx.ext_cx,
$exprs | (($name_ident as $field_type) << $offset)
);
Expand Down
4 changes: 2 additions & 2 deletions tests/support.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ pub fn assert_bind_eq(filename: &str, reference_items_str: &str)

let mut parser = parse::new_parser_from_source_str(ext_cx.parse_sess(), ext_cx.cfg(), "".to_string(), reference_items_str.to_string());
let mut reference_items = Vec::new();
while let Some(item) = parser.parse_item() {
while let Ok(Some(item)) = parser.parse_item() {
reference_items.push(item);
}

Expand All @@ -47,7 +47,7 @@ pub fn assert_bind_eq(filename: &str, reference_items_str: &str)
// rendered versions, which is not beautiful, but should work.
let reference_rendered = render_items(&reference_items);
let generated_rendered = render_items(&generated_items);

if reference_rendered != generated_rendered {
println!("Generated bindings for {} do not match the reference bindings.", filename);
println!("");
Expand Down