Code

Full rewrite#30

Code

Open

michaelbaudino wants to merge 90 commits intomastermichaelbaudino/addic7ed-ruby:masterfrom full-rewritemichaelbaudino/addic7ed-ruby:full-rewriteCopy head branch name to clipboard

+6,225-2,408

Commits

Commits on Jun 15, 2016

• Move download logic to a service object

  michaelbaudino

  committed
  f832859

  Copy full SHA for f832859

• Small refactors and renamings in Addic7ed::Episode

  michaelbaudino

  committed
  79a4050

  Copy full SHA for 79a4050

Commits on Jun 19, 2016

• Rename Addic7edVersionNormalizer and Addic7edCommentNormalizer to VersionNormalizer and CommentNormalizer

  michaelbaudino

  committed
  4198f2a

  Copy full SHA for 4198f2a

• Refactor the parser into 2 service objects

  michaelbaudino

  committed
  8fed841

  Copy full SHA for 8fed841

• Refactor how Episode initializes and holds subtitles

  michaelbaudino

  committed
  3cef498

  Copy full SHA for 3cef498

• Minor: update refactor TODO list

  michaelbaudino

  committed
  62f0c98

  Copy full SHA for 62f0c98

• Rename all service objects to start with a verb

  michaelbaudino

  committed
  d51a0c1

  Copy full SHA for d51a0c1

• Extract services class method to a module

  michaelbaudino

  committed
  1febbd6

  Copy full SHA for 1febbd6

• Move models to a subdirectory

  michaelbaudino

  committed
  b7f2d71

  Copy full SHA for b7f2d71

• Move models *specs* to a subdirectory (forgotten files from last commit 😕)

  michaelbaudino

  committed
  eb1a705

  Copy full SHA for eb1a705

• Refactor ShowList into 2 service objects (a service that downloads and memoizes the shows list and another service that parses that show list to find out how a given show name is URL-encoded by A…

  Show description for 5dd58e1
  michaelbaudino

  committed
  5dd58e1

  Copy full SHA for 5dd58e1

• Refactor URLEncodeShowName to be more readable

  michaelbaudino

  committed
  8097d68

  Copy full SHA for 8097d68

• Require files more smartly

  michaelbaudino

  committed
  5c3bcb2

  Copy full SHA for 5c3bcb2

• Require the gem code in spec_helper rather than in each spec file

  michaelbaudino

  committed
  72cf33d

  Copy full SHA for 72cf33d

• Add a console executable because it's handy

  michaelbaudino

  committed
  387f0b9

  Copy full SHA for 387f0b9

• Allow network requests from the console

  michaelbaudino

  committed
  e3c5334

  Copy full SHA for e3c5334

Commits on Jul 9, 2016

• Move logic from Episode model to a new Search model to better separate concerns and responsabilities

  michaelbaudino

  committed
  f6fe3ba

  Copy full SHA for f6fe3ba

• Add Rubocop and comply to it 👮

  michaelbaudino

  committed
  b299a34

  Copy full SHA for b299a34

• Fix an error with JRuby

  michaelbaudino

  committed
  c84d715

  Copy full SHA for c84d715

• Enable Rubocop for CodeClimate

  michaelbaudino

  committed
  4ab73fc

  Copy full SHA for 4ab73fc

• Use config generated by CodeClimate

  michaelbaudino

  committed
  843bab9

  Copy full SHA for 843bab9

• Enable Brakeman engine for Codeship and disable Fixme engine

  michaelbaudino

  committed
  e40b9f5

  Copy full SHA for e40b9f5

• Don't use single-line Rubocop disables

  michaelbaudino

  committed
  2deebfe

  Copy full SHA for 2deebfe

• Move user agents, languages and URLs to a config file

  michaelbaudino

  committed
  17c2bab

  Copy full SHA for 17c2bab

• Minor one-line refactor

  michaelbaudino

  committed
  25a14ac

  Copy full SHA for 25a14ac

Commits on Jul 11, 2016

• Move compatibility and best-subtitle logics to new CheckCompatibility and SubtitlesCollection classes

  michaelbaudino

  committed
  57d9c58

  Copy full SHA for 57d9c58

• Rename Subtitle#via to Subtitle#source

  michaelbaudino

  committed
  7188b64

  Copy full SHA for 7188b64

Commits on Jul 13, 2016

• Disable Brakeman on CodeClimate as it's Rails-only 😕

  michaelbaudino

  committed
  928edd3

  Copy full SHA for 928edd3

Commits on Jul 16, 2016

• Add support for normalization of subtitles versions with multiple, dash-separated main compatible release groups

  michaelbaudino

  committed
  676938b

  Copy full SHA for 676938b

Commits on Jul 22, 2016

• Fix a typo

  michaelbaudino

  committed
  b5d4836

  Copy full SHA for b5d4836

• Strip parsed subtitle comment

  michaelbaudino

  committed
  ce4e1f3

  Copy full SHA for ce4e1f3

Commits on Jul 23, 2016

• Add doc for models

  michaelbaudino

  committed
  55cbd8e

  Copy full SHA for 55cbd8e

• Change inch badge for v3 branch

  michaelbaudino

  committed
  8214fb8

  Copy full SHA for 8214fb8

• Check GitHub hook for RubyDoc in TODO list

  michaelbaudino

  committed
  165f9a6

  Copy full SHA for 165f9a6

• Change Episode protected methods to be private

  michaelbaudino

  committed
  7034d0d

  Copy full SHA for 7034d0d

• Add missing doc for VideoFile initialize parameter

  michaelbaudino

  committed
  01b521b

  Copy full SHA for 01b521b

• Change Travis email notifications setting

  michaelbaudino

  committed
  9e4e064

  Copy full SHA for 9e4e064

• Fix Travis email notifications setting

  michaelbaudino

  committed
  87587db

  Copy full SHA for 87587db

Commits on Aug 7, 2016

• Bump version to 3.0.0-beta.1 🎉

  michaelbaudino

  committed
  3fef232

  Copy full SHA for 3fef232

Commits on Aug 8, 2016

• Fix internal requiring

  michaelbaudino

  committed
  fb6fd05

  Copy full SHA for fb6fd05

• Bump version to 3.0.0-beta.2

  michaelbaudino

  committed
  dab51b6

  Copy full SHA for dab51b6

• Fix config file requiring

  michaelbaudino

  committed
  96ffed5

  Copy full SHA for 96ffed5

• Bump version to 3.0.0-beta.3

  michaelbaudino

  committed
  06e65d2

  Copy full SHA for 06e65d2

Commits on Aug 11, 2016

• Remove legacy executable script

  michaelbaudino

  committed
  24f0dbd

  Copy full SHA for 24f0dbd

• Bump version to 3.0.0-beta.4

  michaelbaudino

  committed
  737176a

  Copy full SHA for 737176a

Commits on Dec 1, 2016

• Fix a doc typo

  michaelbaudino

  committed
  ea48696

  Copy full SHA for ea48696

Commits on Feb 4, 2017

• Merge branch 'master' into full-rewrite

  michaelbaudino

  committed
  bbceb47

  Copy full SHA for bbceb47

• Minor README changes

  michaelbaudino

  committed
  08db02d

  Copy full SHA for 08db02d

• Update Travis setup

  michaelbaudino

  committed
  e560f6f

  Copy full SHA for e560f6f

• Update RubyGems before Travis builds

  michaelbaudino

  committed
  4a4a101

  Copy full SHA for 4a4a101

• Specify Rubinius version in Travis config

  michaelbaudino

  committed
  46035a2

  Copy full SHA for 46035a2

• Update Rubinius version on Travis

  michaelbaudino

  committed
  03b099d

  Copy full SHA for 03b099d

• Fix README badges

  michaelbaudino

  committed
  6d4276e

  Copy full SHA for 6d4276e

Commits on Aug 13, 2017

• Update Rubocop and comply to new rules

  michaelbaudino

  committed
  7b461d1

  Copy full SHA for 7b461d1

• Run rubocop on Travis

  michaelbaudino

  committed
  1541f45

  Copy full SHA for 1541f45

• Fix specs

  michaelbaudino

  committed
  f40362c

  Copy full SHA for f40362c

• Remove useless dependency to the json gem

  michaelbaudino

  committed
  db37e68

  Copy full SHA for db37e68

• Remove useless allowance of WebMock in bin/console

  michaelbaudino

  committed
  f4de55a

  Copy full SHA for f4de55a

• 🚀 Speedup retrieval of the shows list (by avoiding to use an uber-slow CSS selector). It also massively speeds up the specs by 2000+% (from 93s to 4s on my computer)

  michaelbaudino

  committed
  350805f

  Copy full SHA for 350805f

• Stop using Ruby 2.4+ Regexp.matches? for more backward-compatibility

  michaelbaudino

  committed
  6af8863

  Copy full SHA for 6af8863

• Stop using <<~EOS heredoc syntax for backward compatibility

  michaelbaudino

  committed
  0175a89

  Copy full SHA for 0175a89

• Update Rubinius on Travis

  michaelbaudino

  committed
  24b1674

  Copy full SHA for 24b1674

• Just use the latest varsion of Rubinius on Travis, always

  michaelbaudino

  committed
  23fef08

  Copy full SHA for 23fef08

• Try another syntax for rubinius in Travis, because the documented syntax just doesn't work

  michaelbaudino

  committed
  d28dc57

  Copy full SHA for d28dc57

• Fix Rubinius syntax for Travis AGAIN (╯°□°）╯︵ ┻━┻)

  michaelbaudino

  committed
  33fbff8

  Copy full SHA for 33fbff8

• Minor README update

  michaelbaudino

  committed
  3045492

  Copy full SHA for 3045492

• Bump version

  michaelbaudino

  committed
  da3f583

  Copy full SHA for da3f583

• Add a post-install message to warn that there's no more CLI binary provided by this gem

  michaelbaudino

  committed
  451190f

  Copy full SHA for 451190f

• Update README

  michaelbaudino

  committed
  a4c739d

  Copy full SHA for a4c739d

Commits on Aug 22, 2017

• Change SubtitlesCollection to a proper custom Enumerable

  michaelbaudino

  committed
  35a97d3

  Copy full SHA for 35a97d3

• Allow Episode#page_url to return the URL of the page with subtitles for all languages

  michaelbaudino

  committed
  378e57a

  Copy full SHA for 378e57a

• Make filtering methods of SubtitlesCollection return a SubtitlesCollection again (so that they stay chainable)

  michaelbaudino

  committed
  f76db56

  Copy full SHA for f76db56

Commits on Aug 23, 2017

• Stop overriding select behaviour in SubtitlesCollection

  michaelbaudino

  committed
  086870d

  Copy full SHA for 086870d

Commits on Dec 29, 2017

• Major refactor of models and parsing

  Show description for a208091
  michaelbaudino

  committed
  a208091

  Copy full SHA for a208091

• Explicit some dependencies versions

  michaelbaudino

  committed
  51591be

  Copy full SHA for 51591be

• Add a few items to the TODO list

  michaelbaudino

  committed
  59c9de4

  Copy full SHA for 59c9de4

Commits on Jan 15, 2018

• Add support for MRI 2.5

  michaelbaudino

  committed
  681bf15

  Copy full SHA for 681bf15

• Fix some Rubocop issues

  michaelbaudino

  committed
  cb85386

  Copy full SHA for cb85386

• Add specs placeholders

  michaelbaudino

  committed
  9952328

  Copy full SHA for 9952328

• Release 4.0 beta 7

  michaelbaudino

  committed
  56ccb7c

  Copy full SHA for 56ccb7c

• Fix more Rubocop issues

  michaelbaudino

  committed
  ff53c4e

  Copy full SHA for ff53c4e

Commits on Jan 16, 2018

• More enhancements in README

  michaelbaudino

  committed
  4b95279

  Copy full SHA for 4b95279

• Remove all to_s and inspect overrides

  michaelbaudino

  committed
  9cbc890

  Copy full SHA for 9cbc890

• Add documentation generation instructions

  Show description for 435d97a
  michaelbaudino

  committed
  435d97a

  Copy full SHA for 435d97a

• Remove obsolete configs related to fetching shows and episodes via AJAX

  michaelbaudino

  committed
  4e73a96

  Copy full SHA for 4e73a96

• Remove specs forgotten in 9cbc890

  michaelbaudino

  committed
  ad54fce

  Copy full SHA for ad54fce

• Remove DowloadSubtitle service: it belongs to the CLI

  michaelbaudino

  committed
  b523132

  Copy full SHA for b523132

• Fix a Rubocop complexity issue

  michaelbaudino

  committed
  6087568

  Copy full SHA for 6087568

Commits on Jan 18, 2018

• Add mocks for easy local (and eventually offline) development

  michaelbaudino

  committed
  ef6e2f6

  Copy full SHA for ef6e2f6

Commits on Sep 21, 2018

• Update TODO.md

  michaelbaudino

  authored
  3337a7d

  Copy full SHA for 3337a7d