Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getHttpClient method and deprecate old service proxy #221

Merged
merged 13 commits into from
May 11, 2022

Conversation

davidebianchi
Copy link
Member

@davidebianchi davidebianchi commented May 6, 2022

This is an implementation of #185. The next breaking changes should remove the MICROSERVICE_GATEWAY_SERVICE_NAME required env var

This will resolve:

Checklist

  • your branch will not cause merge conflict with master
  • run npm test
  • tests are included
  • the documentation is updated or integrated accordingly with your changes
  • the code will follow the lint rules and style of the project
  • you are not committing extraneous files or sensible data

@coveralls
Copy link

coveralls commented May 6, 2022

Coverage Status

Coverage decreased (-0.1%) to 97.463% when pulling 0b6353b on add-http-client-method into a0a2d60 on master.

@davidebianchi davidebianchi marked this pull request as ready for review May 6, 2022 18:21
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
lib/httpClient.js Outdated Show resolved Hide resolved
lib/httpClient.js Outdated Show resolved Hide resolved
lib/httpClient.js Outdated Show resolved Hide resolved
lib/httpClient.js Outdated Show resolved Hide resolved
lib/httpClient.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ilteoood ilteoood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/http_client.md Outdated Show resolved Hide resolved
docs/http_client.md Outdated Show resolved Hide resolved
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions related to the doc, the implementation is fine

@davidebianchi
Copy link
Member Author

Update the PR, add also the isMiaHeaderToProxy option to base options

@davidebianchi davidebianchi merged commit b851a9c into master May 11, 2022
@davidebianchi davidebianchi deleted the add-http-client-method branch May 11, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants