Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a conda recipe, update for Windows and webserver compatibility #54

Open
wants to merge 4 commits into
base: maint-3.10
Choose a base branch
from

Conversation

ryanvolz
Copy link

This adds a conda recipe based on the gr_modtool newmod template recipe. It's based on #48 so it can be compatible with the latest GR conda packages. This PR also includes a switch from curses to asciimatics, which is an external dependency (don't love that) but brings Windows compatibility (curses doesn't). This also includes some updates for webserver compatibility with the latest flask-socketio and related packages.

I've tested this by building the packages in CI: https://github.com/ryanvolz/gr-adsb/actions/runs/4671421409. These will packages are now on my anaconda.org channel and will be included in the next release of radioconda.

If you're interested in setting up CI builds based on this recipe, that's a simple change that I can add to this PR.

@mhostetter
Copy link
Owner

Hi @ryanvolz, sorry for the delayed response. I hesitated to merge #48 because I haven't been able to independently test it. It seems people have been using it though. I will work on getting #48 merged into a new branch, probably maint-3.10.

If you can add any CI here, that would be great too. I'm assuming you're thinking GitHub Actions. Thanks again for the contribution.

@ryanvolz
Copy link
Author

No worries! I'll wait for you to get #48 settled and then rebase this, and in the process I'll add the Github Actions CI.

@mhostetter
Copy link
Owner

Ok, thanks. It should be merged now. Let's rebase off of maint-3.10. Thanks!

@ryanvolz ryanvolz changed the base branch from master to maint-3.10 October 31, 2023 14:32
@ryanvolz
Copy link
Author

Done!

@ryanvolz
Copy link
Author

I should note that since gr-adsb doesn't have any compiled code, the CI only has two builds (Linux and Windows) that result in what conda calls "noarch Python" packages. These can be used across platforms and Python versions, except for the fact that Windows is special and so the non-Python files need a slightly different location. So while it doesn't seem like much, the CI artifact packages can be widely used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants