no transform_keys for bulk import contacts #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| REQUEST_BODY: #{env.request_body}\n\n" | ||
| RESPONSE_BODY: #{response.body}\n\n" | ||
| MESSAGE | ||
| rescue StandardError => e |
There was a problem hiding this comment.
ActiveCampaign::Error#message has the variable name 'e'
|
Code Climate has analyzed commit 9f52d04 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no direct/explicit support for bulk import in the SDK, but it can nontheless be invoked with:
res = client.post('import/bulk_import', data)This mostly works but not quite. Bulk import requests use snake_case keys, not camelCase, unlike most of the rest of the API, and the
normalize_bodyprocessing breaks it.client.post('import/bulk_import', data)data should not have all its keys mapped to camelCase, this API will simply ignore e.g
firstName,lastName.This API call, uniquely, uses the keys
contactsandcallback. With this PR, thenormalize_bodymethod now leaves the body alone, in the presence of those keys, as it already did in select other cases.