feat: make msg type generic #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the msg type of an event generic.
Currently, the msg type is not concrete, but had to be something that can be created from
&str, and returned as&str.Making the msg type generic increases the implementation effort for new publishers slightly, because the concrete msg type must be set for the concrete types implementing the traits Entry, ImmediaryEvent, and Filter.
However, the benefit of having a generic msg type outweighs this cost.
All concrete msg types must implement the shallow
Msgtrait.As convenience, the trait is implemented for
String.