Fix new 3.14 C API deprecation for _PyLong_Sign
#2603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
May 9, 2025
Comment on lines
+142
to
+145
| int sign; | ||
| if (!PyLong_GetSign(obj, sign)) { | ||
| return NULL | ||
| } |
There was a problem hiding this comment.
My lack of C++ expertise will show here, but according to the doc: https://docs.python.org/3.14/c-api/long.html#c.PyLong_GetSign
On failure, return -1 with an exception set.
So iiuc, to properly bubble up that exception, I just have to return NULL ? Or is there something else I need to do as well.
Note that the rest of this function always returns FALSE when PyErr_Occurred(). So maybe I want to return FALSE here as well for consistency ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a Python C API Deprecation listed in #2588