Skip to content

Add initial DECIMAL/VT_DECIMAL support #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gesslerpd
Copy link

@gesslerpd gesslerpd commented Apr 18, 2025

Closes #1501 hopefully (I'm more familiar with Python than C++ so this has been a learning experience)

Tested to/from decimal.Decimal translation using local COM interface that uses VT_DECIMAL datatypes.

Thanks for your consideration! Tried to implement similarly to the existing CY/VT_CY implementation since it's similar in some ways.

Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but it would be great to get tests in pycomtest.

@gesslerpd
Copy link
Author

gesslerpd commented Apr 29, 2025

@mhammond Thanks for review! I think I was able to solve the test build issues I was having.

This reverts commit 28bd0c2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no ability to pass VT_DECIMAL VARIANT to methods that accept VARIANT as arguments
2 participants