Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode uri before send #128

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

zombie-king
Copy link

fix for: https://sourceforge.net/p/davmail/mailman/davmail-users/thread/c2c50f73-b87e-f5e9-1f2f-eb28c9da4f04%40free.fr/
duo authentication is broken due to pipe character. Encoding uri fixes that issue. I think only query string should be encoded but the whole relative path is encoded in that patch.

@mguessan
Copy link
Owner

This patch is against old HttpClient 3 code, can you please confirm if it's still relevant with HC4 ?

Impacted code would be arount line 302:

exchangeUri = postLogonMethod(httpClient, postRequest, password).getURI();

@mguessan mguessan added the question Further information is requested label Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants