Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ip addr when ifconfig is missing #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use ip addr when ifconfig is missing #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion acroread
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
main() {
local document="${1}"
local file
local ipaddr

if [[ -z "${document}" ]]; then
document="${HOME}/Documents"
Expand All @@ -13,13 +14,19 @@ main() {
fi
fi

if [[ $(type -p "ifconfig") ]]; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, really sorry I haven't seen this until now. might not be relevant any more...
i would suggest checking the following way:
if type -p ifconfig &> /dev/null; then

ipaddr="ifconfig"
else
ipaddr="ip addr show dev"
fi

docker run --rm -v "${document}:/home/acroread/Documents:rw" \
-v /tmp/.X11-unix:/tmp/.X11-unix \
-v /var/run/cups:/var/run/cups:ro \
-e uid="$(id -u)" \
-e gid="$(id -g)" \
-e DISPLAY="unix${DISPLAY}" \
-e CUPS_SERVER="$(ifconfig docker0 | awk '/^[ ]+inet / {print $2}')" \
-e CUPS_SERVER="$(${ipaddr} docker0 | awk '/^[ ]+inet / {print $2}')" \
-e FILE="${file}" \
--name acroread \
mgor/acroread >& /dev/null
Expand Down