Add linter for rpmspec #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptomilk
force-pushed
the
asn-rpmspec
branch
3 times, most recently
from
2afc57b to
8f1efe1
Compare
cryptomilk
force-pushed
the
asn-rpmspec
branch
from
8f1efe1 to
9d249b1
Compare
|
Added a fixup to fix the tests. Just to be sure: The reported line numbers are 1-based right? (diagnostics lnum is 0 based) |
The reported line numbers by rpmspec are 1-based. |
|
It isn't really clear from the README.md how to run the tests. Just using The fixup commit looks fine for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a linter for RPM spec files.
I miss a simple
make testto quickly run the tests ...